-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[connectors] Add a CLI command confluence upsert-page
#9358
Conversation
> => { | ||
const logger = topLogger.child({ majorCommand: "confluence", command, args }); | ||
switch (command) { | ||
case "upsert-page": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bit of a risk of having some divergence between the cli code and the activities code, we generally try to call an activity from here even if that means it's async.
All that being said I'm fine with having a direct implementation. Any chance we can dry a bit these 2 commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I agree, I was contemplating adding a new activity but in the end we won't do that in the workflow (upsert and check parents right after)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be an option on the activity + a new workflow to do just one page with that option set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm interesting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, doing that 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually it's a bit too convoluted to use the same activity: one fetches the page + upserts without parent and is optimized for the workflow (it does some version checking), the other one fetches the page, fetches the space using the page data, resolves parents and does an upsert with parents.
I added a separate activity to do the upsertWithFullParents
and added workflows since we might want to do these with retries and history
SGTY @spolu ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yess!
88d86df
to
2be5a29
Compare
1131c8b
to
19716ba
Compare
Description
confluence upsert-page
andconfluence upsert-pages
that upsert pages given their IDs.Risk
Deploy Plan